Pruning old states: Use a warning level log instead of fatal #4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
added
Bug
terencechain
approved these changes
Feb 1, 2020
rauljordan
approved these changes
Feb 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #4707 +/- ##
===========================================
- Coverage 55.32% 41.98% -13.34%
===========================================
Files 247 203 -44
Lines 18459 15181 -3278
===========================================
- Hits 10212 6374 -3838
- Misses 6742 7714 +972
+ Partials 1505 1093 -412 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
…iclabs#4707) * Use a warning level log instead of fatal
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
…iclabs#4707) * Use a warning level log instead of fatal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4706.
This isn't a full fix because DeleteStates transaction is rolled back when the transaction fails, but it resolves #4706 which was blocking users starting.