BeaconState: Use copy on write for validator index map #4713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
added
Enhancement
prestonvanloon
requested review from
rauljordan,
shayzluf,
0xKiwi,
terencechain and
nisdas
nisdas
approved these changes
Feb 2, 2020
terencechain
approved these changes
Feb 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #4713 +/- ##
=======================================
Coverage 53.27% 53.27%
=======================================
Files 246 246
Lines 18570 18570
=======================================
Hits 9894 9894
Misses 7239 7239
Partials 1437 1437 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
…#4713) * Use copy on write for validator index map * Merge refs/heads/master into copy-on-write-2
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
…#4713) * Use copy on write for validator index map * Merge refs/heads/master into copy-on-write-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy has practically fallen off the flame graph with this PR!