Propagate blocks again after we process it in pending blocks queue #4714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Feb 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #4714 +/- ##
=======================================
Coverage 26.86% 26.86%
=======================================
Files 202 202
Lines 15200 15200
=======================================
Hits 4084 4084
Misses 10419 10419
Partials 697 697 |
nisdas
approved these changes
Feb 2, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
…rysmaticlabs#4714) * propagate blocks again after we process it in pending blocks queue * Merge refs/heads/master into reprop-block
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
…rysmaticlabs#4714) * propagate blocks again after we process it in pending blocks queue * Merge refs/heads/master into reprop-block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we didn't propagate a block that failed to process when we were missing the parent block, broadcast each block after it has been processed to ensure it reaches the full network.