Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #4716

Merged
merged 3 commits into from Feb 2, 2020
Merged

Minor fixes #4716

merged 3 commits into from Feb 2, 2020

Conversation

prestonvanloon
Copy link
Member

  • Ensure state is copied for cache
  • Ensure pre state exists for attestation before processing in fork choice

@codecov
Copy link

codecov bot commented Feb 2, 2020 •
edited

Codecov Report

Merging #4716 into master will increase coverage by 13.53%.
The diff coverage is 90.9%.

@@             Coverage Diff             @@
##           master    #4716       +/-   ##
===========================================
+ Coverage   41.89%   55.42%   +13.53%     
===========================================
  Files         204      248       +44     
  Lines       15442    18380     +2938     
===========================================
+ Hits         6470    10188     +3718     
+ Misses       7873     6689     -1184     
- Partials     1099     1503      +404

@prestonvanloon prestonvanloon added the Ready For Review A pull request ready for code review label Feb 2, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit bd334c4 into master Feb 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the copy-state-in-cache branch February 2, 2020 05:23
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
@prestonvanloon @cryptomental
Minor fixes (prysmaticlabs#4716)
ceb7774 
* copy state in cache, ensure pre state exists before attepting to process attestation in fork choice
* copy state in cache, ensure pre state exists before attepting to process attestation in fork choice
* fix test
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
@prestonvanloon @cryptomental
Minor fixes (prysmaticlabs#4716)
e5a3fb0 
* copy state in cache, ensure pre state exists before attepting to process attestation in fork choice
* copy state in cache, ensure pre state exists before attepting to process attestation in fork choice
* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prestonvanloon @terencechain