Clean up verify attestation and better error log #4729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5767f07.
Codecov Report
@@ Coverage Diff @@
## master #4729 +/- ##
===========================================
+ Coverage 45.05% 55.63% +10.57%
===========================================
Files 204 249 +45
Lines 15259 18401 +3142
===========================================
+ Hits 6875 10237 +3362
+ Misses 7245 6649 -596
- Partials 1139 1515 +376 |
0xKiwi
approved these changes
Feb 3, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list:
TODO(3603)... Improve and standardize prysm caching #3603 was successfully merged and cache has been on by default w/o any issue for the last monthCould not receive attestation in chain service.... Including slot number, aggregation count, and beacon block root... etc