Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre state of target block does not exist error #4740

Merged
merged 3 commits into from Feb 4, 2020

Conversation

terencechain
Copy link
Member

We still need to save the state (not expensive) because we need to process attestations right after initial sync ends. We also does state pruning during initial sync so it's not a big deal.

This solves the following error:
Screen Shot 2020-02-03 at 5 46 37 PM

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #4740 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4740   +/-   ##
=======================================
  Coverage   27.73%   27.73%           
=======================================
  Files         203      203           
  Lines       15320    15320           
=======================================
  Hits         4249     4249           
  Misses      10355    10355           
  Partials      716      716           

@nisdas nisdas merged commit 80248cd into master Feb 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the init-sync-saves-state branch February 4, 2020 12:19
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
)

* Save state even w/ initial sync cache state flag

* Tested

Co-authored-by: Nishant Das <nish1993@hotmail.com>
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
)

* Save state even w/ initial sync cache state flag

* Tested

Co-authored-by: Nishant Das <nish1993@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants