New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Latest Ethereum APIs Definitions in Prysm #4759
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
API
Api related tasks
Ready For Review
A pull request ready for code review
labels
Feb 5, 2020
rauljordan
requested review from
prestonvanloon,
nisdas,
0xKiwi and
terencechain
February 5, 2020 18:52
nisdas
approved these changes
Feb 5, 2020
0xKiwi
approved these changes
Feb 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #4759 +/- ##
===========================================
- Coverage 58.49% 43.62% -14.88%
===========================================
Files 248 203 -45
Lines 18508 15288 -3220
===========================================
- Hits 10826 6669 -4157
- Misses 6111 7494 +1383
+ Partials 1571 1125 -446 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* include latest ethereumapis and implement streams * add comments and error unimpl * Merge branch 'master' into blocks-stream * add strm * Merge refs/heads/master into blocks-stream * Merge refs/heads/master into blocks-stream * Merge refs/heads/master into blocks-stream * add in mocks * Merge branch 'blocks-stream' of github.com:prysmaticlabs/prysm into blocks-stream * use right mock * gaz * ptypes * gaz * gomock dep * Merge refs/heads/master into blocks-stream
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* include latest ethereumapis and implement streams * add comments and error unimpl * Merge branch 'master' into blocks-stream * add strm * Merge refs/heads/master into blocks-stream * Merge refs/heads/master into blocks-stream * Merge refs/heads/master into blocks-stream * add in mocks * Merge branch 'blocks-stream' of github.com:prysmaticlabs/prysm into blocks-stream * use right mock * gaz * ptypes * gaz * gomock dep * Merge refs/heads/master into blocks-stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tracking issue
Description
Write a summary of the changes you are making
This PR includes the latest Ethereum APIs definitions including ValidatorsInfoStream created by @mcdee and a StreamBlocks RPC endpoint
Link anything that would be helpful or relevant to the reviewers
This PR does not implement the endpoints above, leaving them to separate PRs.