Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block tree cosmetic bugs #4768

Merged
merged 2 commits into from Feb 6, 2020
Merged

Fix block tree cosmetic bugs #4768

merged 2 commits into from Feb 6, 2020

Conversation

terencechain
Copy link
Member

Fixed a few more bugs

  • Don't render page if s.headState == nil since node needs it for weight and vote calculations
  • Don't mark a node as green if it has a best descendent

@terencechain terencechain self-assigned this Feb 6, 2020
@terencechain terencechain added the Enhancement New feature or request label Feb 6, 2020
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #4768 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4768   +/-   ##
======================================
  Coverage    43.9%   43.9%           
======================================
  Files         203     203           
  Lines       15291   15291           
======================================
  Hits         6714    6714           
  Misses       7441    7441           
  Partials     1136    1136

@prylabs-bulldozer prylabs-bulldozer bot merged commit 85b379c into master Feb 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the check-ready branch February 6, 2020 04:49
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* Fixed
* Merge branch 'master' into check-ready
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* Fixed
* Merge branch 'master' into check-ready
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants