Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use balancesLength and randaoMixesLength to save copy on read #4769

Merged
merged 7 commits into from
Feb 6, 2020

Conversation

prestonvanloon
Copy link
Member

Saves a little bit of time / space in epoch processing.

Part of helping with #4673

@prestonvanloon prestonvanloon added the Ready For Review A pull request ready for code review label Feb 6, 2020
@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@365a119). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4769   +/-   ##
=========================================
  Coverage          ?   55.62%           
=========================================
  Files             ?      249           
  Lines             ?    19228           
  Branches          ?        0           
=========================================
  Hits              ?    10695           
  Misses            ?     6966           
  Partials          ?     1567

Copy link
Contributor

@shayzluf shayzluf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had one comment

@rauljordan rauljordan merged commit a9f1de3 into master Feb 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the length-methods branch February 6, 2020 16:06
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
…ticlabs#4769)

* Use balancesLength and randaoMixesLength to save copy on read

* Update beacon-chain/state/getters.go

Co-Authored-By: shayzluf <thezluf@gmail.com>

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: shayzluf <thezluf@gmail.com>
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
…ticlabs#4769)

* Use balancesLength and randaoMixesLength to save copy on read

* Update beacon-chain/state/getters.go

Co-Authored-By: shayzluf <thezluf@gmail.com>

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: shayzluf <thezluf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants