Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster BLS publickey.Copy #4770

Merged
merged 10 commits into from Feb 6, 2020
Merged

Faster BLS publickey.Copy #4770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6ffcee3
Use balancesLength and randaoMixesLength to save copy on read
prestonvanloon Feb 6, 2020
ed4e4d5
use a cheaper copy for BLS publickey.Copy()
prestonvanloon Feb 6, 2020
60d6095
Merge branch 'master' into bls-better-copy
prestonvanloon Feb 6, 2020
951c4b9
Merge refs/heads/master into bls-better-copy
prylabs-bulldozer[bot] Feb 6, 2020
e1c7955
Merge refs/heads/master into bls-better-copy
prylabs-bulldozer[bot] Feb 6, 2020
78d5b5d
Merge refs/heads/master into bls-better-copy
prylabs-bulldozer[bot] Feb 6, 2020
2d186b1
Merge refs/heads/master into bls-better-copy
prylabs-bulldozer[bot] Feb 6, 2020
c004f3e
Merge branch 'master' of github.com:prysmaticlabs/prysm into bls-bett…
prestonvanloon Feb 6, 2020
550f5c4
quick test
prestonvanloon Feb 6, 2020
0653cb1
Merge refs/heads/master into bls-better-copy
prylabs-bulldozer[bot] Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions shared/bls/bls.go
View file
Open in desktop
Expand Up @@ -153,10 +153,8 @@ func (p *PublicKey) Marshal() []byte {

// Copy the public key to a new pointer reference.
func (p *PublicKey) Copy() (*PublicKey, error) {
rawBytes := p.p.Serialize()
newKey := &bls12.PublicKey{}
err := newKey.Deserialize(rawBytes)
return &PublicKey{p: newKey}, err
np := *p.p
return &PublicKey{p: &np}, nil
}

// Aggregate two public keys.
Expand Down
12 changes: 12 additions & 0 deletions shared/bls/bls_test.go
View file
Open in desktop
Expand Up @@ -278,3 +278,15 @@ func TestSignatureFromBytes(t *testing.T) {
})
}
}

func TestPublicKey_Copy(t *testing.T) {
pubkeyA := bls.RandKey().PublicKey()
pubkeyBytes := pubkeyA.Marshal()

pubkeyB, _ := pubkeyA.Copy()
pubkeyB.Aggregate(bls.RandKey().PublicKey())

if !bytes.Equal(pubkeyA.Marshal(), pubkeyBytes) {
t.Fatal("Pubkey was mutated after copy")
}
}