Report unhealthy if we think we are out of sync #4796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
added
Enhancement
terencechain
approved these changes
Feb 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #4796 +/- ##
=========================================
Coverage ? 45.56%
=========================================
Files ? 200
Lines ? 15035
Branches ? 0
=========================================
Hits ? 6851
Misses ? 7093
Partials ? 1091 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Report unhealthy if we think we are out of sync * gofmt * Merge refs/heads/master into out-of-sync-unhealthy
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Report unhealthy if we think we are out of sync * gofmt * Merge refs/heads/master into out-of-sync-unhealthy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the rare case that a node falls out of sync, it should report itself as unhealthy until it is able to catch up to the head of the chain.