Include Beacon Client Package in Slasher #4835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
requested review from
0xKiwi,
nisdas,
prestonvanloon,
shayzluf and
terencechain
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #4835 +/- ##
========================================
Coverage ? 5.88%
========================================
Files ? 5
Lines ? 306
Branches ? 0
========================================
Hits ? 18
Misses ? 284
Partials ? 4 |
0xKiwi
approved these changes
Feb 11, 2020
prestonvanloon
approved these changes
Feb 11, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* begin beacon client * adding in the proper receivers * include all parts of the beacon client * all comments included * visibility and package comment
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* begin beacon client * adding in the proper receivers * include all parts of the beacon client * all comments included * visibility and package comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4836
Description
Write why you are making the changes in this pull request
Currently, slasher does a lot of things in single files, instead of having proper separation of concerns between services.
Write a summary of the changes you are making
This PR creates a
beaconclientpackage inslasherthat initializes a gRPC connection to a beacon node for listening to streamed blocks and attestations. The service then relays received data via aBlockFeed *event.FeedandAttestationFeed *event.Feedother services in the slasher runtime can subscribe to.Link anything that would be helpful or relevant to the reviewers
This PR does not hook-up this service to a main slasher runtime. This will be done in a separate PR once all the difference pieces are built.