Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure lock when accessing the map only #4849

Merged
merged 3 commits into from Feb 13, 2020
Merged

Secure lock when accessing the map only #4849

merged 3 commits into from Feb 13, 2020

Conversation

prestonvanloon
Copy link
Member

Instead of a global lock

@prestonvanloon prestonvanloon added the Ready For Review A pull request ready for code review label Feb 13, 2020
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #4849 into master will decrease coverage by 26.56%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master    #4849       +/-   ##
===========================================
- Coverage   56.64%   30.08%   -26.57%     
===========================================
  Files         249      199       -50     
  Lines       18847    14970     -3877     
===========================================
- Hits        10675     4503     -6172     
- Misses       6673     9716     +3043     
+ Partials     1499      751      -748

@rauljordan rauljordan merged commit f06dfd6 into master Feb 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the better-locking branch February 13, 2020 02:33
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* Secure lock when accessing the map

* wrong lock

* Remove some deadlocks
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* Secure lock when accessing the map

* wrong lock

* Remove some deadlocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants