Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to Custom Hashing for BlockHeaders #4860

Merged
merged 6 commits into from Feb 14, 2020
Merged

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Feb 14, 2020

Uses our custom block header Hash Tree Root instead of the generic method.

@nisdas nisdas added the Ready For Review A pull request ready for code review label Feb 14, 2020
0xKiwi
0xKiwi previously approved these changes Feb 14, 2020
prestonvanloon
prestonvanloon previously approved these changes Feb 14, 2020
@nisdas nisdas dismissed stale reviews from prestonvanloon and 0xKiwi via 576d8b0 February 14, 2020 05:03
@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f109a0a). Click here to learn what that means.
The diff coverage is 88.88%.

@@           Coverage Diff            @@
##             master   #4860   +/-   ##
========================================
  Coverage          ?   57.5%           
========================================
  Files             ?     251           
  Lines             ?   18666           
  Branches          ?       0           
========================================
  Hits              ?   10734           
  Misses            ?    6430           
  Partials          ?    1502

@prylabs-bulldozer prylabs-bulldozer bot merged commit ecfd7bd into master Feb 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the minorOpt branch February 14, 2020 05:19
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* change to custom hashing
* Merge branch 'master' into minorOpt
* goimports
* Merge branch 'minorOpt' of https://github.com/prysmaticlabs/geth-sharding into minorOpt
* gaz
* pad to 32 bytes
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* change to custom hashing
* Merge branch 'master' into minorOpt
* goimports
* Merge branch 'minorOpt' of https://github.com/prysmaticlabs/geth-sharding into minorOpt
* gaz
* pad to 32 bytes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants