fuzzing core/state package without skip slot cache #4883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4883 +/- ##
==========================================
+ Coverage 46.34% 55.64% +9.29%
==========================================
Files 207 254 +47
Lines 15703 18900 +3197
==========================================
+ Hits 7277 10516 +3239
+ Misses 7286 6809 -477
- Partials 1140 1575 +435 |
shayzluf
changed the title
6 tasks
rauljordan
previously approved these changes
Feb 17, 2020
There was a problem hiding this comment.
Thanks @shayzluf these are excellent finds and good nil protection
terencechain
requested changes
Feb 17, 2020
beacon-chain/core/state/state.go
Outdated
| @@ -65,6 +65,9 @@ func GenesisBeaconState(deposits []*ethpb.Deposit, genesisTime uint64, eth1Data | |||
| // Process initial deposits. | |||
| leaves := [][]byte{} | |||
| for _, deposit := range deposits { | |||
| if deposit == nil || deposit.Data == nil { | |||
| return nil, errors.New("eth1data contains nil or deposits with nil data field") | |||
There was a problem hiding this comment.
shouldn't this just be deposits? where is eth1data?
|
PTAL @terencechain |
|
thanks @rauljordan |
terencechain
previously approved these changes
Feb 17, 2020
prestonvanloon
requested changes
Feb 17, 2020
…into fuzz_state_no_cache
…te_no_cache # Conflicts: # beacon-chain/state/getters.go
|
@prestonvanloon PTAL |
prestonvanloon
requested changes
Feb 18, 2020
| var chainStartDepositCount, currentTime uint64 | ||
| for i := 0; i < 100000; i++ { | ||
| fuzzer.Fuzz(&chainStartDepositCount) | ||
| fuzzer.Fuzz(&chainStartDepositCount) |
There was a problem hiding this comment.
by mistake
Suggested change
| fuzzer.Fuzz(&chainStartDepositCount) | |
| fuzzer.Fuzz(¤tTime) |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* fuzzing core/state package * named error msg * err comment * terence feedback * preston feedback * preston feedback Co-authored-by: Raul Jordan <raul@prysmaticlabs.com> Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* fuzzing core/state package * named error msg * err comment * terence feedback * preston feedback * preston feedback Co-authored-by: Raul Jordan <raul@prysmaticlabs.com> Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Part of] #4882
Description
Fuzz test state package and fix errors that have been caught
will include skip slot cache in another pr