Use Memory Pool for Randao Mixes #4896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name = "go_default_library", | ||
| srcs = ["memorypool.go"], | ||
| importpath = "github.com/prysmaticlabs/prysm/shared/memorypool", | ||
| visibility = ["//visibility:public"], |
There was a problem hiding this comment.
anything wrong with it ? it makes sense to make this public as it is in shared
There was a problem hiding this comment.
ah sorry, thought it was in beacon-chain
Co-Authored-By: terence tsao <terence@prysmaticlabs.com>
Codecov Report
@@ Coverage Diff @@
## master #4896 +/- ##
==========================================
+ Coverage 46.18% 47.75% +1.56%
==========================================
Files 207 206 -1
Lines 16578 15338 -1240
==========================================
- Hits 7657 7324 -333
+ Misses 7765 6870 -895
+ Partials 1156 1144 -12 |
Co-Authored-By: terence tsao <terence@prysmaticlabs.com>
terencechain
approved these changes
Feb 18, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* add mem pool * use mem pool * Update shared/memorypool/memorypool.go Co-Authored-By: terence tsao <terence@prysmaticlabs.com> * Update shared/memorypool/memorypool.go Co-Authored-By: terence tsao <terence@prysmaticlabs.com> Co-authored-by: terence tsao <terence@prysmaticlabs.com>
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* add mem pool * use mem pool * Update shared/memorypool/memorypool.go Co-Authored-By: terence tsao <terence@prysmaticlabs.com> * Update shared/memorypool/memorypool.go Co-Authored-By: terence tsao <terence@prysmaticlabs.com> Co-authored-by: terence tsao <terence@prysmaticlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally from #4844 but has been separated into its own PR
The shift to using a memory pool here is so that we can re-use non-referenced objects on the heap which havent been cleared by the GC. This allows us to avoid allocating new memory again and instead we can just re-use it. Since Randao Mixes is one of our most expensive fields when modifying the state, it would be most useful to re-use already destroyed objects instead of allocating a new array.