New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aggregated attestation pool grows large in size #4932
Merged
Merged
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1046998
Add metrics
terencechain d0bdeeb
Use it
terencechain 0d6c831
Use it
terencechain 8ba24b2
Fixed exp time and tests
terencechain 9b9da38
Merge branch 'att-pool-metrics' into fix-exp-time
terencechain 2b5baa3
Update on save too
terencechain c34f169
Expose getters
terencechain ea81cc9
One epoch purge time
terencechain f83bd06
Merge branch 'att-pool-metrics' into fix-exp-time
terencechain 1eb4e61
Fixed a timing issue
terencechain f0696aa
Clean up
terencechain 146e9ee
Gazelle
terencechain 4b4c6cb
Interface
terencechain 975e77b
Merge refs/heads/master into fix-exp-time
prylabs-bulldozer[bot] 31a8010
Prune every epoch
terencechain 0fb48ef
Merge branch 'fix-exp-time' of git+ssh://github.com/prysmaticlabs/pry…
terencechain f4b8c30
Aggregate twice per slot
terencechain 5146c6f
Revert attsToBeAggregated
terencechain 74b104c
Delete expired atts
terencechain File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wouldn't we use the aggregated ones too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed this a problem. Reverted