Replay blocks and generate state without sig verification #4943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Enhancement
Codecov Report
@@ Coverage Diff @@
## master #4943 +/- ##
========================================
Coverage ? 57.3%
========================================
Files ? 265
Lines ? 19800
Branches ? 0
========================================
Hits ? 11347
Misses ? 6849
Partials ? 1604 |
| // ExecuteStateTransitionStateGen applies state transition on input historical state and block for state gen usages. | ||
| // There's no signature verification involved given state gen only works with stored block and state in DB. | ||
| // If the objects are already in stored in DB, one can omit redundant signature checks and ssz hashing calculations. | ||
| // WARNING: This method should not be used for new block. |
There was a problem hiding this comment.
Can this be private? This warning makes me a bit nervous since it is not enforced
There was a problem hiding this comment.
Great point. I have moved it to stategen package and made it private
| @@ -268,6 +273,7 @@ var BeaconChainFlags = append(deprecatedFlags, []cli.Flag{ | |||
| disableStrictAttestationPubsubVerificationFlag, | |||
| disableUpdateHeadPerAttestation, | |||
| enableByteMempool, | |||
| enableStateGenSigVerify, | |||
rauljordan
approved these changes
Feb 26, 2020
delete-merged-branch
bot
deleted the
state-transition-without-sig-checks
branch
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
…abs#4943) * New file * Add transition_stategen.go * Update ProcessBlockForStateRoot * Feature flags * Fixed tests * Gaz * Make them private * E2e flags * Gazelle Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As profiling shows, the biggest bottle neck to regenerate a historical state is 1.) randao signature verification 2.) proposer signature verification.
Given these are historical blocks in the DB, a node should be sure the saved blocks are fully verified. This PR added
ExecuteStateTransitionStateGento enable a cleaner way to replay historical blocks without skip slot cache dependency and extra signature verifications