Better logs for forking #4966
Merged
Better logs for forking #4966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Enhancement
Codecov Report
@@ Coverage Diff @@
## master #4966 +/- ##
=======================================
Coverage 56.21% 56.21%
=======================================
Files 271 271
Lines 21093 21093
=======================================
Hits 11858 11858
Misses 7569 7569
Partials 1666 1666 |
prestonvanloon
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on popular demands, a lot of users have been asking the the logging with regards to fork choice resolving forks look very error-like. I agree that shouldn't be the case. This PR updates the resolving forks messages to to be warning-like and moving fork choice processing from
onAttestationtoReceiveAttestationNoPubsub(one layer top) which is a better place for it