Check HeadState First #4972
Merged
Check HeadState First #4972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
|
Don't Merge this in until it has been tested in runtime, this is mostly follows off #4853 |
Codecov Report
@@ Coverage Diff @@
## master #4972 +/- ##
===========================================
+ Coverage 8.11% 44.70% +36.58%
===========================================
Files 173 208 +35
Lines 12554 16049 +3495
===========================================
+ Hits 1019 7175 +6156
+ Misses 11380 7635 -3745
- Partials 155 1239 +1084 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing an attestation or block, we retrieve the pre-state from the db. This PR makes sure that we check the head state first before retrieving from the db.