Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning if shell expansion characters make it in to the path #5001

Merged
merged 2 commits into from Mar 4, 2020
Merged

Add warning if shell expansion characters make it in to the path #5001

merged 2 commits into from Mar 4, 2020

Conversation

mcdee
Copy link
Contributor

@mcdee mcdee commented Mar 4, 2020

User hit the situation where they wrapped a shell expansion character for the keymanager options in quotes, so the shell did not expand it. Although we cannot prevent this, we can detect it and highlight it in the logs, as otherwise it is not an obvious mistake and can cause user confusion (especially in situations where we try to help by creating the path directory if it doesn't exist rather than erroring).

This prints a suitable warning in the log on detection of this condition.

Resolves #4998 (as much as we can).

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #5001 into master will increase coverage by 5.5%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5001      +/-   ##
==========================================
+ Coverage    9.55%   15.05%    +5.5%     
==========================================
  Files         227      102     -125     
  Lines       17913     7676   -10237     
==========================================
- Hits         1712     1156     -556     
+ Misses      15957     6325    -9632     
+ Partials      244      195      -49

@rauljordan rauljordan merged commit 0bdd0db into prysmaticlabs:master Mar 4, 2020
@mcdee mcdee deleted the keymanager-bad-path-check branch March 4, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keymanageropts path not being expanded
2 participants