Add warning if shell expansion characters make it in to the path #5001
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User hit the situation where they wrapped a shell expansion character for the keymanager options in quotes, so the shell did not expand it. Although we cannot prevent this, we can detect it and highlight it in the logs, as otherwise it is not an obvious mistake and can cause user confusion (especially in situations where we try to help by creating the path directory if it doesn't exist rather than erroring).
This prints a suitable warning in the log on detection of this condition.
Resolves #4998 (as much as we can).