LRU cache for state gen #5004
Merged
LRU cache for state gen #5004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
rauljordan
approved these changes
Mar 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #5004 +/- ##
=======================================
Coverage 25.53% 25.53%
=======================================
Files 79 79
Lines 6723 6723
=======================================
Hits 1717 1717
Misses 4783 4783
Partials 223 223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a LRU cache for state gen pkg.
This was proven to be crucial in #4834 with hit/miss ratio up to >99%. A big piece of mem reductions in the future for state gen