Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load hot state by root #5034

Merged
merged 4 commits into from Mar 8, 2020
Merged

Load hot state by root #5034

merged 4 commits into from Mar 8, 2020

Conversation

terencechain
Copy link
Member

Added functionality to load hot state by root, this is part of new getter for retrieving via the new state mgmt service. Added tests to go along with the implementations

@terencechain terencechain added Ready For Review A pull request ready for code review new-state-mgmt labels Mar 7, 2020
@terencechain terencechain self-assigned this Mar 7, 2020
@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b97e221). Click here to learn what that means.
The diff coverage is 63.63%.

@@            Coverage Diff            @@
##             master    #5034   +/-   ##
=========================================
  Coverage          ?   43.95%           
=========================================
  Files             ?      214           
  Lines             ?    16605           
  Branches          ?        0           
=========================================
  Hits              ?     7298           
  Misses            ?     8020           
  Partials          ?     1287

Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nisdas nisdas merged commit 2452c74 into master Mar 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the load-hot-state-by-root branch March 8, 2020 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants