Use BeaconBlockHeader in place of BeaconBlock for protecting keymanager #5049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5049 +/- ##
==========================================
- Coverage 16.56% 15.03% -1.54%
==========================================
Files 99 103 +4
Lines 7570 7724 +154
==========================================
- Hits 1254 1161 -93
- Misses 6182 6368 +186
- Partials 134 195 +61 |
nisdas
approved these changes
Mar 9, 2020
terencechain
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protecting keymanager currently sends the entire block as part of its signing call. This is unnecessary, as only the relevant roots are required.
This changes the relevant call from using
BeaconBlocktoBeaconBlockHeader, reducing the data passed around (especially important if the signer is remote).