fixes data race in state.Slot #5067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
approved these changes
Mar 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #5067 +/- ##
==========================================
+ Coverage 35.81% 57.61% +21.8%
==========================================
Files 215 270 +55
Lines 16836 20231 +3395
==========================================
+ Hits 6030 11657 +5627
+ Misses 9800 6975 -2825
- Partials 1006 1599 +593 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing tests for initial sync, I've noticed that
BeaconState.Slot()/SetSlot()has a data race condition (on getter we don't obtain mutex). This PR fixes that race.I haven't enabled "race=on" in the
BUILD.bazelbecause there are a lot of data races in other tests of the state package (and I can't jump to that rabbit hole just yet).