Return statuses on duties #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing. Please fix. |
Codecov Report
@@ Coverage Diff @@
## master #5069 +/- ##
==========================================
+ Coverage 6.42% 44.8% +38.37%
==========================================
Files 101 218 +117
Lines 7528 17387 +9859
==========================================
+ Hits 484 7790 +7306
- Misses 6982 8220 +1238
- Partials 62 1377 +1315 |
|
i think i sorted it... lemme know if there's anything else this can't be right tho... can it? |
terencechain
approved these changes
Mar 12, 2020
|
Thanks @tzapu ! Yeah codecov is pretty inaccurate so good to ignore for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5002
Description