HashProto: Use fastssz when available #5218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
previously approved these changes
Mar 26, 2020
prestonvanloon
force-pushed
the
faster-hash-proto
branch
2 times, most recently
from
ba82481
to
0e6b26b
Compare
|
This needs to go into v0.11 because we use hashProto as a database key for some objects |
|
Looks like some tests fail @prestonvanloon |
|
Working on tests now. Some test input is invalid now against ssz types. I'm thinking I want to merge this to master instead of v0.11. |
prestonvanloon
force-pushed
the
faster-hash-proto
branch
from
ace90ba
to
a5051c8
Compare
…to faster-hash-proto-2
nisdas
previously approved these changes
Mar 28, 2020
Co-Authored-By: terence tsao <terence@prysmaticlabs.com>
Codecov Report
@@ Coverage Diff @@
## master #5218 +/- ##
=========================================
Coverage ? 13.49%
=========================================
Files ? 34
Lines ? 3610
Branches ? 0
=========================================
Hits ? 487
Misses ? 3042
Partials ? 81 |
0xKiwi
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After (if the struct meets the interface)