Add Fast Copy of Trie #5221
Merged
Add Fast Copy of Trie #5221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Mar 26, 2020
0xKiwi
approved these changes
Mar 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #5221 +/- ##
=========================================
Coverage ? 56.32%
=========================================
Files ? 289
Lines ? 22490
Branches ? 0
=========================================
Hits ? 12667
Misses ? 8046
Partials ? 1777 |
rauljordan
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce memory usage from the copying of the field trie, we utilize a new method called
FastCopywhich removes all references to the trie in the source state. This is used when the state we are copying from is going to be garbage collected and eventually destroyed.saveHeadNoDBto check our state map first.