Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncomment out cold state tests #5252

Merged
merged 14 commits into from Mar 31, 2020
Merged

Uncomment out cold state tests #5252

merged 14 commits into from Mar 31, 2020

Conversation

terencechain
Copy link
Member

#5230 was accidentally reviewed and merged with commented cold state tests

This PR has fixed and uncommented out those cold state related tests

@terencechain terencechain self-assigned this Mar 30, 2020
@terencechain terencechain added the Ready For Review A pull request ready for code review label Mar 30, 2020
@prestonvanloon
Copy link
Member

Instead of commenting out this code, please use t.Skip("reason") or just delete it. Commented code will never be maintained and will immediately rot.

@terencechain
Copy link
Member Author

Instead of commenting out this code, please use t.Skip("reason") or just delete it. Commented code will never be maintained and will immediately rot.

It wasn't meant to be skipped nor commented, the PR just got merged prematurely and I just noticed it today

@codecov
Copy link

codecov bot commented Mar 30, 2020 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@c8f8e3f). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #5252   +/-   ##
=========================================
  Coverage          ?   46.48%           
=========================================
  Files             ?      232           
  Lines             ?    19156           
  Branches          ?        0           
=========================================
  Hits              ?     8905           
  Misses            ?     8741           
  Partials          ?     1510

@prestonvanloon
Copy link
Member

Oh sorry, I misunderstood the diff and thought you were adding commented code.

prestonvanloon
prestonvanloon previously approved these changes Mar 31, 2020
View reviewed changes
prestonvanloon
prestonvanloon reviewed Mar 31, 2020
View reviewed changes
beacon-chain/state/stategen/cold_test.go
}
}

func TestLoadColdStateByRoot_ByArchivedPoint(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looking

@rauljordan rauljordan merged commit e22365c into master Mar 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the commented-tests branch March 31, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon left review comments

@rauljordan rauljordan rauljordan approved these changes

Assignees

@terencechain terencechain

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terencechain @prestonvanloon @rauljordan