Fix ListValidatorBalances for v0.11
#5458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
Codecov Report
@@ Coverage Diff @@
## master #5458 +/- ##
===========================================
- Coverage 40.80% 20.66% -20.14%
===========================================
Files 236 235 -1
Lines 20569 19819 -750
===========================================
- Hits 8393 4096 -4297
- Misses 10647 15055 +4408
+ Partials 1529 668 -861 |
0xKiwi
reviewed
Apr 16, 2020
| @@ -130,7 +110,7 @@ func (bs *Server) ListValidatorBalances( | |||
| // Otherwise, attempting to paginate 0 balances below would result in an error. | |||
| if balancesCount == 0 { | |||
| return ðpb.ValidatorBalances{ | |||
| Epoch: epoch, | |||
| Epoch: currentEpoch, | |||
There was a problem hiding this comment.
Should this be requestedEpoch?
0xKiwi
previously approved these changes
Apr 16, 2020
0xKiwi
approved these changes
Apr 16, 2020
terencechain
added a commit
that referenced
this pull request
Apr 16, 2020
This reverts commit 3763a8c.
prylabs-bulldozer bot
pushed a commit
that referenced
this pull request
Apr 16, 2020
* Revert "Fix `ListValidatorBalances` for v0.11 (#5458)" This reverts commit 3763a8c. * Revert "Deprecate archival service (#5445)" This reverts commit 4fbcedf. * Revert "Delete archival DB methods (#5459)" This reverts commit 8a3ea1e. * Revert "Modify `ListBeaconCommittees ` to use new state service (#5411)" This reverts commit 497fa6e. * Revert "Modify `GetValidatorParticipation` to use new state service (#5409)" This reverts commit 046a00a. * Revert "Modify `GetValidatorActiveSetChanges` to use new state service (#5408)" This reverts commit 5eb6485. * Revert "Modify `ListValidatorAssignments` to use new state service (#5365)" This reverts commit 5a1a768.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out although
ListValidatorBalanceswas not usingarchivalServicebut it was still usingarchivalDBwhich makes it unfeasible to query historical information. This PR removes the usage ofarchivalDBforListValidatorBalances