Add Metrics to Bootnode #5460
Add Metrics to Bootnode #5460
Conversation
rauljordan
added
Enhancement
| Name: "bootstrap_node_kaddht_peers", | ||
| Help: "The current number of kaddht peers of the bootstrap node", | ||
| }) | ||
| discv5PeersCount = promauto.NewGauge(prometheus.GaugeOpts{ |
There was a problem hiding this comment.
Want to use NewGaugeFunc?
https://godoc.org/github.com/prometheus/client_golang/prometheus#NewGaugeFunc
With that, you could remove that RunEvery routine and prometheus would simply run the function when the metrics page is scraped
There was a problem hiding this comment.
It would end up being more code added cause I would have to call update metrics twice for each of them in the callback, also I wouldn't be able to initialize it at the top as a package var
There was a problem hiding this comment.
Yeah, i was afraid of that
|
this is failing build @rauljordan . You need to update your docker deps too |
rauljordan
dismissed stale reviews from prestonvanloon and terencechain
via
c242f5e
|
build still fails @rauljordan |
|
Build fails |
Codecov Report
@@ Coverage Diff @@
## master #5460 +/- ##
=======================================
Coverage 14.88% 14.88%
=======================================
Files 8 8
Lines 430 430
=======================================
Hits 64 64
Misses 351 351
Partials 15 15 |
Resolves #4217
Description
Write a summary of the changes you are making
Adds kaddht peer count + discv5 peer count to the prometheus metrics of a bootnode.