Use WaitForSynced in validator client for startup #5465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…simplify-validator
…simplify-validator
…simplify-validator
|
Tests fail. Please wait to merge new features until after Topaz starts |
|
Is this unblocked now @0xKiwi ? |
0xKiwi
added
Ready For Review
|
Yes @nisdas |
…simplify-val-client
nisdas
requested changes
Apr 18, 2020
|
I did! This is the validator half but its waiting on #5366 to be merged first so it has changes for both :) |
|
Ah #5366 is meant to be merged first, just saw it. Lets merge that then |
…simplify-val-client
…into simplify-val-client
0xKiwi
commented
Apr 18, 2020
| @@ -178,6 +178,7 @@ func (s *Service) Syncing() bool { | |||
| func (s *Service) Resync() error { | |||
| // set it to false since we are syncing again | |||
| s.synced = false | |||
| // How does the validator handle this? | |||
There was a problem hiding this comment.
Should there be anything special done here? Missed it in the beacon-chain PR.
There was a problem hiding this comment.
Don't think you can, you would have to create new methods in the validator client to handle this.
…simplify-val-client
Codecov Report
@@ Coverage Diff @@
## master #5465 +/- ##
==========================================
+ Coverage 14.88% 19.00% +4.11%
==========================================
Files 8 238 +230
Lines 430 20326 +19896
==========================================
+ Hits 64 3862 +3798
- Misses 351 15869 +15518
- Partials 15 595 +580 |
…simplify-val-client
nisdas
previously approved these changes
Apr 19, 2020
…simplify-val-client
shayzluf
reviewed
Apr 20, 2020
| if err != nil { | ||
| return errors.Wrap(err, "could not setup beacon chain Synced streaming client") | ||
| } | ||
| for { |
There was a problem hiding this comment.
is there a need for this for loop. seem to happen once
rauljordan
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5345, meant to be merged after #5366 , this PR changes the validator client to use
WaitForSyncedto listen for what the validator is ready, rather than pinging if the node is synced every 6 seconds.This feature is gated by the
--wait-for-syncedflag on the validator client.Confirmed in runtime:
Old Startup:
New Startup:
Resolves #5452