Add back archival endpoint ListBeaconCommittees with fallback
#5518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5518 +/- ##
===========================================
- Coverage 54.06% 19.78% -34.28%
===========================================
Files 308 179 -129
Lines 24852 15659 -9193
===========================================
- Hits 13436 3098 -10338
- Misses 9452 12084 +2632
+ Partials 1964 477 -1487 |
prestonvanloon
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added back archival end point
ListBeaconCommitteeswith a proper fallback when--disable-new-state-mgmtis appliedThe PR cherry picked #5411 was already approved and the fallback logic was already used in the wild. There's no new logic and nothing substantive here.
Tested first 100 epochs:
