Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel Initial Sync Properly #5529

Merged
merged 4 commits into from
Apr 20, 2020
Merged

Cancel Initial Sync Properly #5529

merged 4 commits into from
Apr 20, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Apr 20, 2020

Adds a cancel field for the context cancel function, so that we can release our sync services properly.

@nisdas nisdas requested a review from a team as a code owner April 20, 2020 03:10
@nisdas nisdas added the Ready For Review A pull request ready for code review label Apr 20, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 639e307 into master Apr 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the cancelServices branch April 20, 2020 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@farazdagi farazdagi Awaiting requested review from farazdagi

@terencechain terencechain Awaiting requested review from terencechain

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nisdas @prestonvanloon