Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slasher historic attestation detection #5532

Merged
merged 3 commits into from
Apr 20, 2020

Conversation

shayzluf
Copy link
Contributor

[Resolves] #5531


Description

writes latest detected head every epoch and not just at historic detection end

@shayzluf shayzluf requested a review from a team as a code owner April 20, 2020 09:08
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #5532 into master will increase coverage by 8.84%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #5532      +/-   ##
==========================================
+ Coverage   12.59%   21.44%   +8.84%     
==========================================
  Files         115      270     +155     
  Lines        9169    22344   +13175     
==========================================
+ Hits         1155     4791    +3636     
- Misses       7811    16780    +8969     
- Partials      203      773     +570     

@shayzluf shayzluf added the Ready For Review A pull request ready for code review label Apr 20, 2020
@rauljordan rauljordan merged commit fae307e into master Apr 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix_slasher_historic_attestation_detection branch April 20, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants