Regen and save historical states as default #5544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
rauljordan
previously approved these changes
Apr 20, 2020
| return err | ||
| // For whatever reason if node is unable to delete a state due to | ||
| // state is finalized, it is more reasonable to continue than to exit. | ||
| continue |
rauljordan
reviewed
Apr 20, 2020
| @@ -54,6 +56,10 @@ func (kv *Store) regenHistoricalStates(ctx context.Context) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| cacheState, err := lru.New(int(params.BeaconConfig().SlotsPerEpoch) * 2) | |||
There was a problem hiding this comment.
can this cache size be at the top of the file as a const
There was a problem hiding this comment.
It's never used again so we should let this be GC'd after this method returns
prestonvanloon
approved these changes
Apr 20, 2020
prestonvanloon
approved these changes
Apr 20, 2020
| @@ -54,6 +56,10 @@ func (kv *Store) regenHistoricalStates(ctx context.Context) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| cacheState, err := lru.New(int(params.BeaconConfig().SlotsPerEpoch) * 2) | |||
There was a problem hiding this comment.
It's never used again so we should let this be GC'd after this method returns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5537
Change list:
--disable-new-state-mgmtflag is offTested it ~10 times using the DBs in Minio. Can confirm this implementation is reliably working
