Log warn instead of return error #5547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
0xKiwi
approved these changes
Apr 20, 2020
rauljordan
approved these changes
Apr 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #5547 +/- ##
==========================================
- Coverage 23.46% 23.02% -0.45%
==========================================
Files 270 235 -35
Lines 22465 20421 -2044
==========================================
- Hits 5271 4701 -570
+ Misses 16383 14796 -1587
- Partials 811 924 +113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5395
Log warn instead of return err if state deletion fails
Noted this code path is only for
--diable-new-state-mgmtso almost no risk for current master