Change ListIndexedAttestations to convert attestations from target root #5548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
approved these changes
Apr 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #5548 +/- ##
==========================================
- Coverage 23.02% 19.95% -3.07%
==========================================
Files 235 238 +3
Lines 20421 20568 +147
==========================================
- Hits 4701 4104 -597
- Misses 14796 15795 +999
+ Partials 924 669 -255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes ListIndexedAttestations to convert attestations using the target root, instead of using the block root which requires a new state generated for every slot.