Change Validator Status for visible deposit back to DEPOSITED #5563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5563 +/- ##
===========================================
- Coverage 43.54% 22.83% -20.71%
===========================================
Files 275 267 -8
Lines 23325 22629 -696
===========================================
- Hits 10156 5167 -4989
- Misses 11309 16485 +5176
+ Partials 1860 977 -883 |
prestonvanloon
requested changes
Apr 21, 2020
…nto val-status
Co-Authored-By: Preston Van Loon <preston@prysmaticlabs.com>
Co-Authored-By: Preston Van Loon <preston@prysmaticlabs.com>
|
Ready @prestonvanloon |
…nto val-status
rauljordan
approved these changes
Apr 21, 2020
prestonvanloon
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR undoes a change in #5396 where we changed how a validator was considered DEPOSITED. Understandably it caused some confusion so that change is being reverted so the validator can be shown as DEPOSITED when their eth1 deposit is found.