Add a 2 second timeout to fetching eth1data #5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKiwi
reviewed
Apr 22, 2020
|
Fixing tests now |
Codecov Report
@@ Coverage Diff @@
## master #5583 +/- ##
==========================================
- Coverage 27.46% 5.02% -22.45%
==========================================
Files 239 239
Lines 20771 20655 -116
==========================================
- Hits 5705 1038 -4667
- Misses 14070 19466 +5396
+ Partials 996 151 -845 |
nisdas
approved these changes
Apr 23, 2020
terencechain
approved these changes
Apr 23, 2020
| @@ -169,11 +175,13 @@ func (vs *Server) eth1Data(ctx context.Context, slot uint64) (*ethpb.Eth1Data, e | |||
| // Look up most recent block up to timestamp | |||
| blockNumber, err := vs.Eth1BlockFetcher.BlockNumberByTimestamp(ctx, eth1VotingPeriodStartTime) | |||
| if err != nil { | |||
| return nil, errors.Wrap(err, "could not get block number from timestamp") | |||
| log.WithError(err).Error("Failed to get block number from timestamp") | |||
There was a problem hiding this comment.
We also could consider warning for these, i dont feel strongly for either, up to you!
There was a problem hiding this comment.
Its an error that should be monitored
This was referenced Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR returns a random eth1data vote if the node has an issue retrieving data from eth1 in a timely manner.
Resolves #5521