Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GenesisValidatorsRoot to GetGenesis #5619

Merged
merged 14 commits into from Apr 27, 2020
Merged

Add GenesisValidatorsRoot to GetGenesis #5619

merged 14 commits into from Apr 27, 2020

Conversation

0xKiwi
Copy link
Contributor

@0xKiwi 0xKiwi commented Apr 25, 2020

What type of PR is this?
Improvement

What does this PR do? Why is it needed?

This PR adds GenesisValidatorsRoot to the result of GetGenesis, so any RPC request for genesis info has all the info it needs.

@0xKiwi 0xKiwi requested a review from a team as a code owner April 25, 2020 16:57
@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #5619 into master will increase coverage by 53.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5619       +/-   ##
===========================================
+ Coverage    1.47%   54.60%   +53.12%     
===========================================
  Files          69      310      +241     
  Lines        6516    26012    +19496     
===========================================
+ Hits           96    14203    +14107     
- Misses       6411     9800     +3389     
- Partials        9     2009     +2000     

@0xKiwi 0xKiwi added the Ready For Review A pull request ready for code review label Apr 26, 2020
Copy link
Contributor

@shayzluf shayzluf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shayzluf shayzluf merged commit eb5513f into master Apr 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the add-val-root-genesis branch April 27, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants