More efficient ancestor head retrieval for GetAttestationData
#5669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Enhancement
terencechain
added
Blocked
|
Marking this as blocked to merge. I want to test it for few more hours |
Codecov Report
@@ Coverage Diff @@
## master #5669 +/- ##
==========================================
+ Coverage 14.90% 19.93% +5.03%
==========================================
Files 116 239 +123
Lines 9328 20825 +11497
==========================================
+ Hits 1390 4152 +2762
- Misses 7711 15878 +8167
- Partials 227 795 +568 |
prestonvanloon
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
In the event of head slot > request slot, the node starts fetching ancestor head root recursively until the condition satisfies. Every slot is a DB look up.
Instead, we can use
helpers.BlockRootAtSlot(headState, req.Slot)to limit the DB look up to just one time.Which issues(s) does this PR fix?
Could be relevant to #5665
Other notes for review
Tested with my 3k validators with both
enable-new-state-mgmton and off