Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator key files: allow symlinks #5679

Merged
merged 9 commits into from Apr 29, 2020
Merged

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Apr 29, 2020

What type of PR is this?
Bug

What does this PR do? Why is it needed?

  • Validator key files may be symlinked, if they are - currently keystore ignores them
  • This PR adds link following

Which issues(s) does this PR fix?

Fixes #5412

Other notes for review
N/A

@farazdagi farazdagi requested a review from nisdas April 29, 2020 16:15
@farazdagi farazdagi self-assigned this Apr 29, 2020
@farazdagi farazdagi marked this pull request as ready for review April 29, 2020 17:39
@farazdagi farazdagi requested a review from a team as a code owner April 29, 2020 17:39
@farazdagi farazdagi added the Ready For Review A pull request ready for code review label Apr 29, 2020
prestonvanloon
prestonvanloon previously approved these changes Apr 29, 2020
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #5679 into master will increase coverage by 2.38%.
The diff coverage is 60.00%.

@@            Coverage Diff            @@
##           master   #5679      +/-   ##
=========================================
+ Coverage    1.38%   3.77%   +2.38%     
=========================================
  Files          69      73       +4     
  Lines        6477    6834     +357     
=========================================
+ Hits           90     258     +168     
- Misses       6379    6523     +144     
- Partials        8      53      +45     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 2c1e3aa into master Apr 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the account-keys-symlinks branch April 29, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keys that are symlinks are not read
2 participants