Update pubsub seen cache to be per epoch instead of per slot #5698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
previously approved these changes
Apr 30, 2020
prestonvanloon
previously approved these changes
Apr 30, 2020
This reverts commit bd638ae.
|
e2e failure? |
terencechain
dismissed stale reviews from prestonvanloon and rauljordan
via
ea41603
Yep. Fixed. Updated the description |
prestonvanloon
approved these changes
Apr 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #5698 +/- ##
==========================================
+ Coverage 22.66% 26.44% +3.78%
==========================================
Files 276 239 -37
Lines 24033 20892 -3141
==========================================
+ Hits 5446 5524 +78
+ Misses 17575 14293 -3282
- Partials 1012 1075 +63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5655
This updates the "seen" cache to be per epoch instead of per slot
Note: I only updated the seen cache to per epoch for
aggregatedattestation. Theunaggregatedattestation is still uses per slot because trackingslot + bitfieldis CHEAPER than trackingvalidator index + epoch. Computing validator index requires getting the state from DB which is more expensiveReferences:
ethereum/consensus-specs#1706
ethereum/consensus-specs#1710