Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state gen migration #5858

Merged
merged 8 commits into from May 14, 2020
Merged

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented May 14, 2020

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?
To ensure archived state gets periodically saved during initial syncing. During initial syncing, if the node starts at 0, migration will not save archived states along the way

Which issues(s) does this PR fix?
Fixes #5851

Other notes for review

@terencechain terencechain requested a review from a team as a code owner May 14, 2020 19:12
@terencechain terencechain self-assigned this May 14, 2020
@terencechain terencechain added Bug Something isn't working Ready For Review A pull request ready for code review labels May 14, 2020
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #5858 into master will decrease coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5858      +/-   ##
==========================================
- Coverage   60.27%   59.99%   -0.29%     
==========================================
  Files         312      312              
  Lines       26860    26229     -631     
==========================================
- Hits        16191    15735     -456     
+ Misses       8521     8356     -165     
+ Partials     2148     2138      -10     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 2f27966 into master May 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-migration-delete-latest-state branch May 14, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListValidatorBalances RPC is very slow for historic epochs (new state mgmt)
3 participants