Allow wallet passphrases to be environment variables #5879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5879 +/- ##
==========================================
+ Coverage 59.97% 60.20% +0.22%
==========================================
Files 314 313 -1
Lines 26712 26493 -219
==========================================
- Hits 16021 15950 -71
+ Misses 8510 8380 -130
+ Partials 2181 2163 -18 |
nisdas
reviewed
May 17, 2020
validator/keymanager/wallet_test.go
Outdated
| } | ||
| }() | ||
|
|
||
| if err := os.Setenv("NEITHER", "neither"); err != nil { |
There was a problem hiding this comment.
Could you unset the environment variables after the test is done ?
There was a problem hiding this comment.
Thanks, added. Also altered the names to use a test-specific prefix to avoid any chance of clash.
prestonvanloon
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
The wallet keymanager allows passphrases to be stored in a JSON file, however some configurations do better with sensitive data injected through environment variables. This PR attempts to interpolate passphrases starting with the '$' character as environment variables, allowing for this configuration without losing the use of the JSON file.