Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing block tree viewer #5880

Merged
merged 4 commits into from May 16, 2020
Merged

Enhancing block tree viewer #5880

merged 4 commits into from May 16, 2020

Conversation

terencechain
Copy link
Member

Made the following enhancements to block tree viewer (http://localhost:8080/tree)

Change list:

  • Removed index field. Proposers don't care which index the block is in the proto array. This info was too low level
  • Removed best descendent field. Proposers don't care the index of the best descendent and the best descendent can be seen as green
  • Added graffiti field. It makes it easier to debug whose proposers submitted the forked blocks. Super useful to debug multi client testnet. If we agree this is too verbose, we also can remove it before mainnet.

@terencechain terencechain added Enhancement New feature or request Ready For Review A pull request ready for code review labels May 16, 2020
@terencechain terencechain requested a review from a team as a code owner May 16, 2020 18:34
@terencechain terencechain self-assigned this May 16, 2020
@codecov
Copy link

codecov bot commented May 16, 2020

Codecov Report

Merging #5880 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5880   +/-   ##
=======================================
  Coverage   60.22%   60.22%           
=======================================
  Files         314      314           
  Lines       27356    27356           
=======================================
  Hits        16475    16475           
  Misses       8659     8659           
  Partials     2222     2222           

@terencechain terencechain merged commit 337ae69 into master May 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the graf branch May 16, 2020 19:29
michaelhly pushed a commit to michaelhly/prysm that referenced this pull request May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants