Make ETH1Data Determination More Strict #5944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.12 #5944 +/- ##
==========================================
- Coverage 59.22% 59.19% -0.03%
==========================================
Files 319 319
Lines 26869 26876 +7
==========================================
- Hits 15912 15910 -2
- Misses 8782 8790 +8
- Partials 2175 2176 +1 |
0xKiwi
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Update to Spec v0.12
What does this PR do? Why is it needed?
We make sure that the eth1data cannot refer to a previous version of the deposit
trie by requiring all new eth1data have a deposit count higher than or equal to the
current one in the head state.
Which issues(s) does this PR fix?
Part of #5935 , and follows from this PR in the spec:
ethereum/consensus-specs#1836
Other notes for review