Merge validator databases #5968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # validator/accounts/BUILD.bazel # validator/accounts/account.go # validator/accounts/account_test.go # validator/main.go
rkapka
commented
May 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #5968 +/- ##
==========================================
- Coverage 59.99% 59.48% -0.52%
==========================================
Files 319 319
Lines 27376 26945 -431
==========================================
- Hits 16425 16027 -398
+ Misses 8749 8739 -10
+ Partials 2202 2179 -23 |
rauljordan
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR introduces the ability to merge several validator databases into one database by means of a new command:
validator accounts merge.Which issues(s) does this PR fix?
This is one of several PRs addressing #5638.
Other notes for review