New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init sync arbitrary batch length + full bandwidth utilization #5978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
farazdagi
requested review from
prestonvanloon,
terencechain,
0xKiwi,
nisdas,
rauljordan and
shayzluf
and removed request for
shayzluf,
0xKiwi and
prestonvanloon
May 26, 2020 13:00
Codecov Report
@@ Coverage Diff @@
## master #5978 +/- ##
==========================================
- Coverage 59.89% 59.54% -0.35%
==========================================
Files 321 320 -1
Lines 27632 26991 -641
==========================================
- Hits 16549 16073 -476
+ Misses 8866 8731 -135
+ Partials 2217 2187 -30 |
…abs/prysm into init-sync-arbitrary-batch-len
nisdas
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Refactoring+Optimization
What does this PR do? Why is it needed?
Relevant PR
Other notes for review
--dev
flag, when syncing from genesis, you'll will occasionally see around 100blks/sec. Overall, speed of syncing is ~70-80blks/sec.init-sync
was quite a fun project).--dev
flag).